search

jupyter / jupyter_client

Jupyter protocol client APIs
https://jupyter-client.readthedocs.io
BSD 3-Clause "New" or "Revised" License
374 stars 279 forks source link

Minor Fixes. #1009

Closed Carreau closed 5 months ago

Carreau commented 5 months ago

I'm investigating an issue where Jupyter-Console does not and it seem there are mixup between sync and async KernelManager and other in a few places.

Basically both Async and Blocking KM are expected by the type system to work as KM independently, but obviously some have Async methods and other have Sync methods, which need to be awaited.

When touching traitlets config files it's easy to change the default class from Sync to async, and then you get weird error messages.

So dropping a few asserts here and fixign a few types while investigating.

I think the Sync and Async should be more distinct now that we are mostly async everywhere to avoid those confusions.

Carreau commented 5 months ago

Thanks for the review. I don't want to argue about things like this and I don't want to make it a real error.