search

jupyter / jupyter_client

Jupyter protocol client APIs
https://jupyter-client.readthedocs.io
BSD 3-Clause "New" or "Revised" License
390 stars 283 forks source link

zmq.Poller is not async #1022

Closed fcollonval closed 6 months ago

fcollonval commented 6 months ago

The line https://github.com/jupyter/jupyter_client/blob/0a19278ed8d4090080a44760498a38ad9d4e0d99/jupyter_client/client.py#L533 makes the code blocking.

We should use zmq.asyncio.Poller.

fcollonval commented 6 months ago

Seen when working on https://github.com/datalayer/jupyter-server-nbmodel, when manually testing the code, jupyter-server requests are blocked.