jupyter / jupyter_client

Jupyter protocol client APIs
https://jupyter-client.readthedocs.io
BSD 3-Clause "New" or "Revised" License
383 stars 283 forks source link

Fix connection reconciliation to handle restarts #882

Closed kevin-bates closed 1 year ago

kevin-bates commented 1 year ago

The changes delivered in #879 did not account for scenarios when ports have changed during restarts - which tends to occur with remote kernels. As a result, we need to reset the connection file when the connection information returned from the provisioner differs from the file's contents, rather than raise a ValueError.

Although this is probably not an issue in typical situations, it is something that should be fixed. I apologize to @blink1073 for having not caught this in my initial changes in #879 since two different releases were cut following those changes.

blink1073 commented 1 year ago

@meeseeksdev please backport to 7.x