Closed gibsondan closed 1 year ago
I wonder if this is the same issue that we're seeing with nbclient+jupyter_client 8: https://github.com/jupyter/nbclient/issues/272
Our CI also started failing, and we narrowed it down to jupyter_client 8 (we run some of our examples with papermill, which uses jupyter_client).
we didn't try downgrading to jupyter_client 7 since we already built an in-house notebook executor, and migrating to it fixed the issues.
Ah, this was a gap in testing for nbclient
, because we've been testing it against main
as a downstream project.
I'm closing this in favor of https://github.com/jupyter/nbclient/issues/272.
Actually the error is in this repo, I'm investigating in #925
Hello,
Starting last week, a test in the Dagster papermill / jupyter integration started hanging. The hang coincided with a number of jupyter-related releases, but we were able to isolate the problem to the
jupyter-client
8 release - downgrading to the previous release made the problem go away.To reproduce the problem:
python_modules/libraries/dagstermill
folder, run:tox -vv -e py38 -- -k test_hello_world -x -s
The test will hang while executing a notebook, but the hang will go away if you force the previous version of jupyter-client to be installed instead.
Code in Dagster that executes the notebook: https://github.com/dagster-io/dagster/blob/master/python_modules/libraries/dagstermill/dagstermill/factory.py#L194-L213
Console output during the hang (this shows forever):
Stack trace of the notebook while execution is hanging:
Let me know if any other information would be helpful.