search

jupyter / jupyter_client

Jupyter protocol client APIs
https://jupyter-client.readthedocs.io
BSD 3-Clause "New" or "Revised" License
383 stars 283 forks source link

Make cache_ports configurable with default value of False. #956

Closed jkitchin closed 1 year ago

jkitchin commented 1 year ago

This addresses issue #878 and #955. Suggested by @kevin-bates.

jkitchin commented 1 year ago

I guess I should have added a label. I don't know what this would be considered, I guess an enhancement?

kevin-bates commented 1 year ago

I don't know what this would be considered, I guess an enhancement?

Given the previous discussion a while ago, I view this change as something that should have been part of the original change and have applied the bug label.

jkitchin commented 1 year ago

Does anything else need to happen to this?

kevin-bates commented 1 year ago

We usually give folks a day or two to review. However, the build issue is also unwarranted but I believe it is probably unrelated.

@blink1073 - is the coverage issue due to some external version update or something like that? (Sorry, I haven't been "close" to the repos lately.)

blink1073 commented 1 year ago

The coverage thing is a weird artifact from switching away from codecov where it seems like coverage isn't honoring relative_files = true in some cases. I've seen this on nbconvert as well.

blink1073 commented 1 year ago

I'll cut a new release early next week.

kevin-bates commented 1 year ago

Thank you Steve!