search

jupyter / jupyter_client

Jupyter protocol client APIs
https://jupyter-client.readthedocs.io
BSD 3-Clause "New" or "Revised" License
374 stars 279 forks source link

Unused `*args` in `KernelManager`'s `__init__` #986

Closed Carreau closed 8 months ago

Carreau commented 9 months ago

I think that if it is unused, then it is likely a mistake from the caller that meant to pass a kwarg.

Should it maybe get a deprectation period ?

blink1073 commented 9 months ago

Yeah I think it should be deprecated and removed in 9.0.

ccordoba12 commented 9 months ago

+1 from me too to what @blink1073 said. I think we use *args in our subclass of KernelManager.

Carreau commented 8 months ago

Rebased on main, should fix linting.