Fix client 7 and 8 compat

jupyter / jupyter_console

Jupyter Terminal Console

http://jupyter-console.readthedocs.io/en/latest/

BSD 3-Clause "New" or "Revised" License

248 stars 146 forks source link

Fix client 7 and 8 compat #276

Closed blink1073 closed 1 year ago

blink1073 commented 1 year ago

Addresses https://github.com/jupyter/jupyter_client/issues/927

NeilGirdhar commented 1 year ago

Thanks for fixing this so fast. FYI, I'm having the same problem with completions: https://github.com/jupyter/jupyter_console/issues/277

QuLogic commented 1 year ago

It seems like the two enabled tests in jupyter_console/tests/test_console.py are a bit flaky. Sometimes one fails, sometimes the other fails, sometimes they both pass just fine, just from running the test suite over and over a few times. This is with Python 3.11.2, jupyter-core 5.1.0, jupyter-client 7.4.9, and prompt-toolkit 3.0.36.