jupyter / kernel_gateway_demos

Demos associated with the kernel gateway incubator project
BSD 3-Clause "New" or "Revised" License
152 stars 76 forks source link

use latest python image #64

Closed heiderich closed 4 years ago

heiderich commented 5 years ago

Fixes #63.

echarles commented 5 years ago

Works for me. A well defined version is better imho, e.g. 3.7.3-alpine3.9

heiderich commented 5 years ago

What do others think? To me it is not clear which would be better. Choosing a fixed version may increase the likelihood that this will continue to function if the python:latest containers change quicker than this repository and may possibly lead to an incompatibility. Using python:latest has the advantage of revealing possible incompatibilities quicker. So I guess the question is whether you rather want it to work in a (possibly old) environment or rather detect incompatibilities at an early stage in the kernel gateway demos (and possibly the kernel gateway itself).

nscozzaro commented 5 years ago

Please pull it in to save others' time. I wasted an hour debugging it myself, just to then stumble across this pull request that already solves the issue.