jupyter / nb2kg

Other
73 stars 31 forks source link

Fix support for tornado 6 #24

Closed kevin-bates closed 5 years ago

kevin-bates commented 5 years ago

Now that tornado 6 has been released, we need to fix the websocket handler subclass to yield/await its superclass call to get(). Failures to do so result in messages like the following (note this will only appear when DEBUG is enabled):

[D 07:27:42.239 NotebookApp] Initializing websocket connection /api/kernels/e192ca76-dc43-4779-9afa-8a32bc23a1a0/channels
/opt/anaconda3/envs/nb2kg-dev/lib/python3.7/site-packages/nb2kg/handlers.py:87: RuntimeWarning: coroutine 'WebSocketHandler.get' was never awaited
  super(WebSocketChannelsHandler, self).get(kernel_id=kernel_id, *args, **kwargs)

This was reported relative to the gateways in: https://github.com/jupyter/enterprise_gateway/issues/597