search

jupyter / nb2kg

Other
73 stars 31 forks source link

Add keepalive websocket ping #29

Closed esevan closed 5 years ago

esevan commented 5 years ago

When nb2kg server is behind the proxy closing idle stream connection such as nginx and envoy websocket is closed and reconnected. This behavior updates kernel last_activity so that it keeps kernel_gateway from culling kernels.

This change is from WebsocketMixin in jupyter/notebook.

Signed-off-by: Eunsoo Park esevan.park@gmail.com

kevin-bates commented 5 years ago

This brings up an interesting issue. How to dictate dependency versions? As a result, I think we should probably bump the minimal Notebook version to 5.7.8.

esevan commented 5 years ago

@kevin-bates Oh.. sorry. I tested this only in my env. My fault..T^T. I deliberately changed tornado version dependency for compatibility with other server extensions using older version of tornado. I'm using notebook==5.7.2, tornado==4.5.3. I'm going to rebase this by testing with tornado >= 5.0.