Don't pass username/password through to HTTP client when not set.

jupyter / nb2kg

Other

73 stars 31 forks source link

Don't pass username/password through to HTTP client when not set. #7

Closed GrahamDumpleton closed 6 years ago

GrahamDumpleton commented 6 years ago

As per #6, this PR addresses issue where username/password get passed through to HTTP client even when not set, meaning that Authorization header for token gets overridden with basic authentication header with empty username/password values.

lresende commented 6 years ago

LGTM