jupyter / nb2kg

Other
73 stars 31 forks source link

Fix running kernels display #9

Closed kevin-bates closed 6 years ago

kevin-bates commented 6 years ago

After further analysis it turns out that Notebook versions > 5.0.0 exhibit this problem. This issue started happening once Notebook PR 2559 was submitted for 5.1.0.rc1 to distinguish notebook instances from other active "sessions" that can also reside in the session table. What is used by the java-script to set the 'Running' indicator is produced by the row_to_model() method.

nb2kg was still using the older model definition that did not include the type value. As a result, notebook sessions (i.e., active kernels) were not getting displayed.

This change brings the model used in nb2kg up to date, thereby enabling the proper display of active kernels. At some point, we should figure out a way to leverage the superclass method, but nb2kg uses futures that, when attempting to remove, caused issues upstream.

Fixes #8