search

jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension
https://nbclassic.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
75 stars 62 forks source link

Correct version python file? #101

Closed echarles closed 2 years ago

echarles commented 2 years ago

What is the best way to define the version for nbclassic, taking into account the jupyter_releaser process

For now, the check_release job is failing (see. https://github.com/jupyter/nbclassic/runs/6521439283?check_suite_focus=true) with

0.0.4
:: Bumping from 0.3.7 to 0.0.5
Error: nbclassic/__version__.py does not exist
Traceback (most recent call last):

Should we readd a __version__.py file that reexports the __version__ defined in _version.py. In that case, will the jupyter_releaser still be happy?

Any advice welcome here

cc/ @blink1073 @Zsailer

blink1073 commented 2 years ago

It should be nbclassic/_version.py in pyproject.toml. It is using a regex to read the version from the file.

echarles commented 2 years ago

Thx @blink1073 I have opened https://github.com/jupyter/nbclassic/pull/102 to fix the releaser ci job and it is now failing with error: [Errno 2] No such file or directory: 'pybabel' on https://github.com/jupyter/nbclassic/runs/6524838596?check_suite_focus=true#step:9:1284