search

jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension
https://nbclassic.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
69 stars 60 forks source link

Upgrade to marked 4.0.10 #201

Closed echarles closed 1 year ago

echarles commented 1 year ago

Fixes https://github.com/jupyter/nbclassic/issues/200

RRosio commented 1 year ago

Hi @echarles, thank you for the ping to review! I was trying this out locally before merging and I noticed some weird behavior with trying to change a code cell to a markdown cell. Instead of converting the cell the via Esc + M or the menu option, an empty white line was added after the cells. I'm wondering if this is something present for you as well? It seems the version of marked that my system is grabbing upon install is 4.0.19.

https://user-images.githubusercontent.com/12378147/214329902-f48b30d3-9003-41d3-bed6-2a3870fcee31.mov

echarles commented 1 year ago

Great catch @RRosio. My last commit should fix the issue you have pointed.

4.0.19 is the latest one that respects ~4.0.10.

RRosio commented 1 year ago

@echarles awesome thank you! Indeed that issue no longer appears! I'll merge this in!

echarles commented 1 year ago

Thx @RRosio