search

jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension
https://nbclassic.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
69 stars 60 forks source link

Add news banner and log #215

Closed echarles closed 1 year ago

echarles commented 1 year ago

Related to https://github.com/jupyter/nbclassic/issues/214

This PR add a banner and log message. The user can click on a button to not see the banner anymore (that choice is persisted across session and server restart via the local storage).

Screenshot 2023-02-16 at 14 19 35 Screenshot 2023-02-16 at 14 19 57
echarles commented 1 year ago

@jupyter/notebook-council As this PR introduces a very visible change for the users, I am looking for any feedback/enhancement.

echarles commented 1 year ago

Thx @RRosio for the review. Let's leave this open a few more days for any feedback before merging.

echarles commented 1 year ago

Thx a lot @isabela-pf. I have merged your suggestions.

ellisonbg commented 1 year ago

Question - isn't our plan to deprecate and not support notebook 6 moving forward. Do we have a date as to when notebook 6 will stop being supported? If that is the case, don't we want to phrase this to communicate that to users? The phrasing "if you plan..." suggests that upgrading is entirely optional for users.

ellisonbg commented 1 year ago

The JEP on noteobook 7 says "Jupyter Notebook v6 will be maintained with critical security fixes for two years following the release of Jupyter Notebook v7." I think the banner should communicate that to users.

ellisonbg commented 1 year ago

I should note though that I think a banner like this is a fine idea and will be helpful for users to understand the plan.

echarles commented 1 year ago

isn't our plan to deprecate and not support notebook 6 moving forward.

Yes, that is the plan

Do we have a date as to when notebook 6 will stop being supported?

We had a few discussions in the community meeting related to support policies for Notebook, but nothing has been proposed nor decided to my knowledge and understanding.

If that is the case, don't we want to phrase this to communicate that to users? The phrasing "if you plan..." suggests that upgrading is entirely optional for users.

Well, I think the upgrade is optional indeed. As we don't have a EOL support date, I guess we could say "Notebook 6... will soon be deprecated..."

Please note that this banner will for now be shipped for NbClassic, so we may remove the mention to Notebook 6 to make the message more clear.

Also the primary intent of this banner is to highlight that any custom Notebook extensions will stop working with Notebook 7, instead of focussing on any depreciation or invitation to migrate to Notebook 7.

echarles commented 1 year ago

The JEP on noteobook 7 says "Jupyter Notebook v6 will be maintained with critical security fixes for two years following the release of Jupyter Notebook v7." I think the banner should communicate that to users.

Thank you for the pointer. Do you have a content that we could use as text for the banner?

echarles commented 1 year ago

BTW since the JEP, Notebook has evolved to NbClassic as a Jupyter Server extension, not sure if that 2 years support also applies to NbClassic.

echarles commented 1 year ago

The result of the Notebook community meeting discussions can be read on https://github.com/jupyter/notebook-team-compass/issues/5#issuecomment-1085254000

echarles commented 1 year ago

The changes are at the nbclassic template and jupyter server extensions levels. As such, they will not show up in Notebook 6.x distributions, even after a new nbclassic release.

We can thus open other PR on the Notebook branches to add similar features (banner + log), but with different messages and focus if needed.

echarles commented 1 year ago

I have updated this PR based on feedbacks collected here and in https://github.com/jupyter/nbclassic/issues/214, and opened https://github.com/jupyter/notebook/pull/6737/files

echarles commented 1 year ago

@RRosio https://github.com/jupyter/notebook/pull/6737 is merged and https://jupyter-notebook.readthedocs.io/en/latest/migrate_to_notebook7.html is lie

This PR is good to merge so we can cut a release.

echarles commented 1 year ago

CI is failing with 

    bower xterm.js-fit#*                           EHTTP Status code of 502
    /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-build-env-etjzzr96/overlay/lib/python3.7/site-packages/setuptools/command/easy_install.py:147: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      EasyInstallDeprecationWarning,
RRosio commented 1 year ago

CI is failing with

    bower xterm.js-fit#*                           EHTTP Status code of 502
    /private/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/pip-build-env-etjzzr96/overlay/lib/python3.7/site-packages/setuptools/command/easy_install.py:147: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
      EasyInstallDeprecationWarning,

I read that pip install -e . is the equivalent of running python setup.py develop and that uses(?) EasyInstall? Could we try running python3 -m pip install --user -e . for the job to avoid this error? Although I didn’t check too far back, the error seems to have begun appearing in action 278 and has been intermittently happening ever since. I did see that the version of setuptools installed for packaging changed to setuptools-67.3.2 wheel-0.38.4 ever since action 278. I just opened a PR for a small link update and the same error appeared in the check_release (link_check) but not the check_release (check_release). It doesn't seem to be related to any changes from this PR specifically, if it sounds good to you @echarles I will merge!

echarles commented 1 year ago

I have relaunched the CI and the intermediary 502 returned by unpkg is now fixed.

@RRosio this is good to merge. Thx.