search

jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension
https://nbclassic.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
69 stars 60 forks source link

Missing icons in the news banner on 0.5.2 #223

Closed jtpio closed 1 year ago

jtpio commented 1 year ago

Trying Notebook 7, JupyterLab 4 and NBClassic installed together on Binder with https://gist.github.com/jtpio/35a72862c8be13dee31b61ebac2d9786

It appears the icons in the banner added in https://github.com/jupyter/nbclassic/pull/215 are not rendered properly (using Firefox 110 on Fedora 37):

image

jtpio commented 1 year ago

Ah a quick check seems to indicate this was fixed in https://github.com/jupyter/nbclassic/pull/220 (but probably not released yet).

echarles commented 1 year ago

Thx for reporting. This has been fixed in https://github.com/jupyter/nbclassic/pull/220

We need to cut a release with that.

jtpio commented 1 year ago

ok thanks for the confirmation.

Closing as fixed!