jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension
https://nbclassic.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
69 stars 60 forks source link

Add an option to disable the news / Notebook 7 migration banner #242

Closed andrii-i closed 1 year ago

andrii-i commented 1 year ago

215 introduced news / Notebook 7 migration banner. This a good informational feature for self-managed users but it presents problems in settings where user's environment is managed and updating something can lead to environment breaking or not working properly.

In Notebook 7 you can disable the banner display using show_banner trait (#6808). Making the same option available in nbclassic would solve the problem.

matthew-brett commented 1 year ago

Agree - this is frustrating and confusing for our users of a JupyterHub cluster.

echarles commented 1 year ago

I can work on this begin next week.

echarles commented 1 year ago

See https://github.com/jupyter/notebook_shim/pull/29 and https://github.com/jupyter/nbclassic/pull/243

This feature can take some time as depends on a new notebook_shim release.

santiagobasulto commented 1 year ago

I added this bit to custom.css as a quick fix for now:

#newsId {
    display: none
}
santiagobasulto commented 1 year ago

@RRosio thanks! which version of nbclassic is this/will this fix tied to?

echarles commented 1 year ago

@santiagobasulto this will be available in the next release. I will try to cut one this week.

echarles commented 1 year ago

@santiagobasulto nbclassic 0.5.6 is released and allows you to disable the banner display with --NotebookApp.show_banner=False.

santiagobasulto commented 1 year ago

Thanks @echarles!!!

matthew-brett commented 1 year ago

My attempt to apply this config to a JupyterHub setup : https://github.com/lisds/lisds-images/commit/4ced0704a103356e40fb72d342a28b24751eb0a8