jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension
https://nbclassic.readthedocs.io/en/latest
BSD 3-Clause "New" or "Revised" License
73 stars 63 forks source link

Make terminals_available false if key is not in settings dict yet #261

Closed RRosio closed 1 year ago

RRosio commented 1 year ago

Partial fix for #255 identified by @defjaf

RRosio commented 1 year ago

Not sure the CI failures are related (some checks are also failing with #259).

I recently took a look at these CI failures for another PR as well as here and I agree that they don't seem to be related! I will go ahead and merge this. Thank you for taking a look @jtpio!