templates/login.html: fix 404s in offsite How to set a password docs, link to TLS/SSL if scheme!=https - Githubissues

jupyter / nbclassic

Jupyter Notebook as a Jupyter Server extension

https://nbclassic.readthedocs.io/en/latest

BSD 3-Clause "New" or "Revised" License

74 stars 62 forks source link

templates/login.html: fix 404s in offsite How to set a password docs, link to TLS/SSL if scheme!=https #288

Open westurner opened 3 months ago

westurner commented 3 months ago

Description

The links to how to set a password are 404ing https://github.com/jupyter/nbclassic/blob/main/nbclassic/templates/login.html
They could also link to how to TLS/SSL if scheme!=https
These docs could be included in the app, so that they work without internet access

Reproduce

Cause a login failure e.g. by opening http://localhost:8888/?token=invalidtoken
404: Click the " enable a password. " or " the documentation on how to enable a password " links

[ ] https://jupyter-notebook.readthedocs.io/en/stable/public_server.html is gone?
[x] https://jupyter-notebook.readthedocs.io/en/v6.5.4/public_server.html remains
[ ] DOC,SEC: also add a conditional link to #using-ssl-for-encrypted-communication
[ ] DOC: include these docs in nbclassic/templates/login.html

Expected behavior

the link to the offsite, online docs on how to set a password should not 404

Context

Operating System and version:
Browser and version:
Jupyter NbClassic version:

Troubleshoot Output

Paste the output from running `jupyter troubleshoot` from the command line here.
You may want to sanitize the paths in the output.

Command Line Output

Paste the output from your command line running `jupyter nbclassic` here, use `--debug` if possible.

Browser Output

Paste the output from your browser Javascript console here, if applicable.

RRosio commented 3 months ago

Thank you for opening this issue! Feel welcome to submit any PRs!