jupyter / nbclient

A client library for executing notebooks. Formally nbconvert's ExecutePreprocessor
https://nbclient.readthedocs.io/en/latest/
BSD 3-Clause "New" or "Revised" License
152 stars 55 forks source link

ipykernel.comm.Comm is deprecated #292

Closed frenzymadness closed 1 year ago

frenzymadness commented 1 year ago

And therefore tests of nbclient fail with the latest ipykernel with:

E             Full diff:
E               [
E             +  ,
E             -  {'name': 'stderr',
E             -   'output_type': 'stream',
E             -   'text': '<IPY-INPUT>:1: DeprecationWarning: The `ipykernel.comm.Comm` class '
E             -           'has been deprecated. Please use the `comm` module instead.For '
E             -           'creating comms, use the function `from comm import create_comm`.\n'
E             -           "  comm = Comm('this-comm-tests-a-missing-handler', data={'id': "
E             -           "'foo'})\n"},
E               ]

in test_run_all_notebooks[Other Comms.ipynb-opts0].

davidbrochart commented 1 year ago

I just ran this test with the latest ipykernel, and it passes successfully. Actually, the Other Comms.ipynb notebook is doing the right thing by using the comm module. What version of nbclient are you testing?

frenzymadness commented 1 year ago

You are right, I'm sorry for the noise. I was testing an older version of nbclient with the latest ipykernel.

davidbrochart commented 1 year ago

No worries, thanks for your work on packaging!