Open kloczek opened 2 years ago
@kloczek Note that our CI tests set up some dummy git config before running. Maybe you need to do something similar on your system? I'm not sure what you mean with "Looks like git command is incorrectly used" ?
I did not chenge anything in my build procesure and on testing 3.1.1 I see only on eunit failing now
+ PYTHONPATH=/home/tkloczko/rpmbuild/BUILDROOT/python-nbdime-3.1.1-2.fc35.x86_64/usr/lib64/python3.8/site-packages:/home/tkloczko/rpmbuild/BUILDROOT/python-nbdime-3.1.1-2.fc35.x86_64/usr/lib/python3.8/site-packages
+ /usr/bin/pytest -ra
=========================================================================== test session starts ============================================================================
platform linux -- Python 3.8.15, pytest-7.2.0, pluggy-1.0.0
rootdir: /home/tkloczko/rpmbuild/BUILD/nbdime-3.1.1, configfile: pytest.ini, testpaths: nbdime/tests
plugins: anyio-3.6.2
collected 5754 items
nbdime/tests/test_apply_merge.py .. [ 0%]
nbdime/tests/test_args.py ..... [ 0%]
nbdime/tests/test_autoresolve.py ..... [ 0%]
nbdime/tests/test_cli_apps.py ..............................ssss [ 0%]
nbdime/tests/test_decision_tools.py ...........x. [ 1%]
nbdime/tests/test_diff.py .. [ 1%]
nbdime/tests/test_diff_format.py ........................................................................................................................ [ 3%]
nbdime/tests/test_diff_gitrefs.py .................... [ 3%]
nbdime/tests/test_diff_json_conversion.py .x [ 3%]
nbdime/tests/test_diff_performance.py . [ 3%]
nbdime/tests/test_diff_sequence.py .. [ 3%]
nbdime/tests/test_diff_sequence_bruteforce.py . [ 3%]
nbdime/tests/test_diff_sequence_difflib.py . [ 3%]
nbdime/tests/test_directory_differ.py .... [ 3%]
nbdime/tests/test_git_diffdriver.py ........ [ 3%]
nbdime/tests/test_git_filter_integration.py ............ [ 4%]
nbdime/tests/test_hg_differ.py sss. [ 4%]
nbdime/tests/test_js_artifacts_installed.py F [ 4%]
nbdime/tests/test_merge.py ....x........... [ 4%]
nbdime/tests/test_merge_format.py .............................................................................. [ 5%]
nbdime/tests/test_merge_notebooks.py ....................................................................................x.xxx...s....s..sss.... [ 7%]
nbdime/tests/test_merge_notebooks_inline.py .......s..s.s....................... [ 8%]
nbdime/tests/test_myers.py ... [ 8%]
nbdime/tests/test_notebook_diff.py ................................................................................................................................. [ 10%]
.................................................................................................................................................................... [ 13%]
.................................................................................................................................................................... [ 16%]
.................................................................................................................................................................... [ 19%]
.................................................................................................................................................................... [ 21%]
.................................................................................................................................................................... [ 24%]
.................................................................................................................................................................... [ 27%]
.................................................................................................................................................................... [ 30%]
.................................................................................................................................................................... [ 33%]
.................................................................................................................................................................... [ 36%]
.................................................................................................................................................................... [ 39%]
.................................................................................................................................................................... [ 41%]
.................................................................................................................................................................... [ 44%]
.................................................................................................................................................................... [ 47%]
.................................................................................................................................................................... [ 50%]
.................................................................................................................................................................... [ 53%]
.................................................................................................................................................................... [ 56%]
.................................................................................................................................................................... [ 58%]
.................................................................................................................................................................... [ 61%]
.................................................................................................................................................................... [ 64%]
.................................................................................................................................................................... [ 67%]
.................................................................................................................................................................... [ 70%]
.................................................................................................................................................................... [ 73%]
.................................................................................................................................................................... [ 76%]
.................................................................................................................................................................... [ 78%]
.................................................................................................................................................................... [ 81%]
.................................................................................................................................................................... [ 84%]
.................................................................................................................................................................... [ 87%]
.................................................................................................................................................................... [ 90%]
.................................................................................................................................................................... [ 93%]
.................................................................................................................................................................... [ 96%]
.................................................................................................................................................................... [ 98%]
..... [ 98%]
nbdime/tests/test_package.py . [ 98%]
nbdime/tests/test_patch.py ... [ 99%]
nbdime/tests/test_prettyprint.py ..................... [ 99%]
nbdime/tests/test_server_extension.py .................... [ 99%]
nbdime/tests/test_utils.py ..... [ 99%]
nbdime/tests/test_web.py ....xxxxx [100%]
================================================================================= FAILURES =================================================================================
_____________________________________________________________________ test_nbdime_js_artifacts_present _____________________________________________________________________
def test_nbdime_js_artifacts_present():
from nbdime.webapp import __file__ as webapp_init
static_folder = os.path.join(os.path.dirname(webapp_init), 'static')
targets = [os.path.join(static_folder, 'nbdime.js')]
missing = [t for t in targets if not os.path.exists(t)]
if missing:
> raise ValueError(('missing files: %s' % missing))
E ValueError: missing files: ['/home/tkloczko/rpmbuild/BUILD/nbdime-3.1.1/nbdime/webapp/static/nbdime.js']
/home/tkloczko/rpmbuild/BUILD/nbdime-3.1.1/nbdime/tests/test_js_artifacts_installed.py:11: ValueError
============================================================================= warnings summary =============================================================================
nbdime/config.py:5
/home/tkloczko/rpmbuild/BUILD/nbdime-3.1.1/nbdime/config.py:5: DeprecationWarning: Jupyter is migrating its paths to use standard platformdirs
given by the platformdirs library. To remove this warning and
see the appropriate new directories, set the environment variable
`JUPYTER_PLATFORM_DIRS=1` and then run `jupyter --paths`.
The use of platformdirs will be the default in `jupyter_core` v6
from jupyter_core.paths import jupyter_config_path
nbdime/tests/test_cli_apps.py::test_nbmerge_app_null_side
/usr/lib/python3.8/site-packages/nbformat/__init__.py:128: MissingIDFieldWarning: Code cell is missing an id field, this will become a hard error in future nbformat versions. You may want to use `normalize()` on your notebooks before validations (available since nbformat 5.1.4). Previous versions of nbformat are fixing this issue transparently, and will stop doing so in the future.
validate(nb)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
========================================================================= short test summary info ==========================================================================
SKIPPED [7] nbdime/tests/conftest.py:69: requires mercurial
SKIPPED [1] nbdime/tests/test_merge_notebooks.py:579: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks.py:700: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks.py:776: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks.py:797: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks.py:827: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks_inline.py:180: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks_inline.py:284: unconditional skip
SKIPPED [1] nbdime/tests/test_merge_notebooks_inline.py:331: unconditional skip
XFAIL nbdime/tests/test_decision_tools.py::test_build_diffs_unsorted
XFAIL nbdime/tests/test_diff_json_conversion.py::test_diff_to_json_patch - reason: Not comparing to jsonpatch
XFAIL nbdime/tests/test_merge.py::test_deep_merge_lists_delete_no_conflict__currently_expected_failures - reason: [NOTRUN] flaws in deep diffing of lists, not identifying almost equal sublists
XFAIL nbdime/tests/test_merge_notebooks.py::test_merge_multiline_cell_source_conflict
XFAIL nbdime/tests/test_merge_notebooks.py::test_merge_interleave_cell_add_remove
XFAIL nbdime/tests/test_merge_notebooks.py::test_merge_conflicts_get_diff_indices_shifted
XFAIL nbdime/tests/test_merge_notebooks.py::test_merge_inserts_within_deleted_range
XFAIL nbdime/tests/test_web.py::test_fetch_diff - reason: [NOTRUN] yield tests were removed in pytest 4.0 - test_fetch_diff will be ignored
XFAIL nbdime/tests/test_web.py::test_api_diff - reason: [NOTRUN] yield tests were removed in pytest 4.0 - test_api_diff will be ignored
XFAIL nbdime/tests/test_web.py::test_fetch_merge - reason: [NOTRUN] yield tests were removed in pytest 4.0 - test_fetch_merge will be ignored
XFAIL nbdime/tests/test_web.py::test_api_merge - reason: [NOTRUN] yield tests were removed in pytest 4.0 - test_api_merge will be ignored
XFAIL nbdime/tests/test_web.py::test_offline_mathjax - reason: [NOTRUN] yield tests were removed in pytest 4.0 - test_offline_mathjax will be ignored
FAILED nbdime/tests/test_js_artifacts_installed.py::test_nbdime_js_artifacts_present - ValueError: missing files: ['/home/tkloczko/rpmbuild/BUILD/nbdime-3.1.1/nbdime/webapp/static/nbdime.js']
=================================================== 1 failed, 5726 passed, 15 skipped, 12 xfailed, 2 warnings in 56.06s ====================================================
Here is list of installed modules in build env
The test failure you indicate states that one of the JS build artifacts are missing. If you do a pip install, it will build and make sure that the JS artifacts are copied over as well. Not sure what would be needed to support setup.py build + install.
The test failure you indicate states that one of the JS build artifacts are missing. If you do a pip install, it will build and make sure that the JS artifacts are copied over as well. Not sure what would be needed to support setup.py build + install.
Just tested 4.0.1 and pytest still is failing in the same unit and I have all modules listed in pyptoject.toml dependencies installed. here is pytest output
Just tested 4.0.1 and pytest still is failing in the same unit [...]
Hi, and thanks for your feedback. You say it is failing in the same unit, but it seems to me that it is a completely different test that is failing this time? Do you perhaps have something else running on the port that the unit test in question is trying to use?
Do you perhaps have something else running on the port that the unit test in question is trying to use?
Not possible. Im building all my rpm packages inside freshy spawned LXC zone in which ae only installed build dependencies listed in rpm spec file.
The test failure you indicate states that one of the JS build artifacts are missing
npm during build shows that everything has been installed. However it shows one repeating warnig about one file
I'm trying to package your module as an rpm package. So I'm using the typical build, install and test cycle used on building packages from non-root account.
Looks like git command is incorrectly used.