Notebook 7: meta-issue - Githubissues

jupyter / nbdime

Tools for diffing and merging of Jupyter notebooks.

http://nbdime.readthedocs.io

Other

2.62k stars 158 forks source link

Notebook 7: meta-issue #726

Open fcollonval opened 8 months ago

fcollonval commented 8 months ago

Here are some issues reported targeting notebook 7:

[ ] notebook toolbar buttons are disabled: https://github.com/jupyterlab/jupyterlab-git/issues/1284

vidartf commented 7 months ago

Just for reference: What needs to be done on the nbdime side here?

fcollonval commented 7 months ago

As notebook v7 is using the JupyterLab command defined there: https://github.com/jupyter/nbdime/blob/2f856dac3b889d48fb0cf2140335e6a78afaa49f/packages/labextension/src/plugin.ts#L212

The issue comes from the isEnabled logic and the addition of the widget to the shell:

https://github.com/jupyter/nbdime/blob/2f856dac3b889d48fb0cf2140335e6a78afaa49f/packages/labextension/src/plugin.ts#L225

As it will be a no-op in notebook v7: https://github.com/jupyter/notebook/blob/29d665dbac144d143d843168da9823cab6498b0a/packages/application/src/shell.ts#L318

There are ways to now if the extension is running within JupyterLab or Notebook:

having optional token dependency specific to one or the other
using the app.name (like in that extension e.g.)

Those could be used to tune the command behavior.

Related issue opened in notebook : https://github.com/jupyter/notebook/issues/7134