search

jupyter / nbformat

Reference implementation of the Jupyter Notebook format
http://nbformat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
265 stars 152 forks source link

Catch AttributeErrors thrown by ipython_genutils during conversion as ValidationErrors #240

Closed therzka closed 2 years ago

therzka commented 2 years ago

This change allows an error to be thrown and more context to be provided at the time of conversion if a notebook is malformed but isn't caught by validation at read time instead of a generic KeyError

MSeal commented 2 years ago

Thanks for adding improvements to the repo. I'm going to merge we need to drop 3.5 anyway