search

jupyter / nbformat

Reference implementation of the Jupyter Notebook format
http://nbformat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
262 stars 153 forks source link

Should normalize update minor_version? #328

Open vidartf opened 1 year ago

vidartf commented 1 year ago

Currently if I run a v 4.0 notebook through nbformat.validator.normalize, it will add cell ids, but it will leave the minor version as 0. Shouldn't it be updated to 5 to highlight that it now includes some fields that was added in that version of the schema? Since the previous versions have the schema with additionalProperties: false, the new notebook will be invalid against the 4.0 schema.

blink1073 commented 1 year ago

Yes, it makes sense to me that whenever a normalize occurs, it should bump to the version that was used to normalize.