jupyter / nbformat

Reference implementation of the Jupyter Notebook format
http://nbformat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
265 stars 152 forks source link

Undeprecate validate(nb, relax_add_props=True) #343

Closed minrk closed 1 year ago

minrk commented 1 year ago

There is no equivalent behavior in normalize, so I don't think this shouldn't have been deprecated along with the other normalizing steps. relax_add_props is purely related to validation, not normalization since no changes are made, it only changes what is checked. The case for it still exists and is still relevant (in nbconvert preprocessor validation), so I think it should be kept.

This change (respecting the deprecation in nbconvert) has caused notebooks to fail on nbviewer: https://nbviewer.org/github/ibtassam1/SQL_Vancouver/blob/03f9f1e5dbd2c3e13965c01d125f5c9ab371d696/Vancouver%20Public%20Services_v3.ipynb

Deprecation was added in #282