jupyter / nbformat

Reference implementation of the Jupyter Notebook format
http://nbformat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
262 stars 153 forks source link

Should `trusted` metadata be documented in notebook file format? #349

Open krassowski opened 1 year ago

krassowski commented 1 year ago

nbformat (Python package) handles trusted as described in https://nbformat.readthedocs.io/en/latest/api.html#module-nbformat.sign. The Cell metadata chapter of the Notebook file format does not describe trusted. Should trusted be added to specification, or is this an implementation detail which was intentionally omitted? If it is omitted by choice, what is the right place to document/discuss quirks around it?

Cross-referencing related discussions:

westurner commented 1 year ago

W3C LD-PROOFS (& JSONLD) would be a better solution than the helpful existing ad-hoc digital signature solution:

On Sun, Feb 19, 2023, 4:41 PM Michał Krassowski @.***> wrote:

nbformat (Python package) handles trusted as described in https://nbformat.readthedocs.io/en/latest/api.html#module-nbformat.sign. The Cell metadata https://nbformat.readthedocs.io/en/latest/format_description.html#cell-metadata chapter of the Notebook file format does not describe trusted. Should trusted be added to specification, or is this an implementation detail which was intentionally omitted? If it is omitted by choice, what is the right place to document/discuss quirks around it?

Cross-referencing related discussions:

— Reply to this email directly, view it on GitHub https://github.com/jupyter/nbformat/issues/349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAMNSZOWG4JPV44PPKQR6LWYKHPNANCNFSM6AAAAAAVBGAQJ4 . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Carreau commented 1 year ago

IIRC, trust metadata should not be part of the format as is should be only a transiant key that is not saved.

krassowski commented 1 year ago

If that is not part of nbformat, then where should the specification for it live?

Carreau commented 1 year ago

Good question, it use to be that the schema/validation had two modes: