jupyter / nbformat

Reference implementation of the Jupyter Notebook format
http://nbformat.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
259 stars 153 forks source link

Revert PR #378 (Simplify NotebookNotary._data_dir_default) #397

Closed krassowski closed 5 months ago

krassowski commented 5 months ago

Reverts https://github.com/jupyter/nbformat/pull/378 to close https://github.com/jupyter/nbformat/issues/396.

This is because the breakage was also reported in the wild, see:

ivanov commented 5 months ago

I'd like to keep https://github.com/jupyter/nbformat/issues/396 open to think through alternatives or improvements

Nevermind that last part, the only remaining issue belongs in jupyter_core, so I opened https://github.com/jupyter/jupyter_core/issues/397

krassowski commented 5 months ago

Thanks for the merge! Another downstream affected: https://github.com/widgetti/ipyvuetify/pull/301

@blink1073 a new patch release would be highly valued (once you have time to look at it)

blink1073 commented 5 months ago

Done!

krassowski commented 5 months ago

Thank you!