Make hashing independent of notebook content - Githubissues

jupyter / nbgrader

A system for assigning and grading notebooks

https://nbgrader.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

1.3k stars 317 forks source link

Make hashing independent of notebook content #1774

Closed tuncbkose closed 5 months ago

tuncbkose commented 1 year ago

Currently, changing the content of a submitted notebook breaks feedback distribution (see some discussion in https://github.com/jupyter/nbgrader/issues/1202). This is because feedback distribution uses a hash that depends on the notebook content.

This pr aims to solve this issue by duplicating the timestamp.txt mechanism. A submission_secret.txt file containing a random string is created during submission, and the notebook hash is changed to depend only on this file and notebook name.

Should fix #1712

github-actions[bot] commented 1 year ago

:point_left: Launch a Binder on branch AaltoSciComp/nbgrader/hash

danielmaitre commented 12 months ago

I like this solution and would also solve some of the issues I am facing!

tuncbkose commented 5 months ago

Thanks for the review. I'll rebase within a day or two and ping you

tuncbkose commented 5 months ago

@brichet rebased.

brichet commented 5 months ago

Thanks @tuncbkose

LukasMueller187 commented 5 months ago

Happy to see this. :tada: Was manually applying the PR every update. Thanks @tuncbkose