search

jupyter / nbgrader

A system for assigning and grading notebooks
https://nbgrader.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.3k stars 317 forks source link

Remove jupyter_notebook_config.json since notebook server is not supported anymore #1807

Closed lahwaacz closed 1 year ago

lahwaacz commented 1 year ago

There is already jupyter_server_config.d/nbgrader.json and I don't see why jupyter_notebook_config.json should be any different.

github-actions[bot] commented 1 year ago

Binder :point_left: Launch a Binder on branch lahwaacz/nbgrader/move-jupyter-notebook-config

lahwaacz commented 1 year ago

@brichet What do you think about this change?

brichet commented 1 year ago

Thanks @lahwaacz. As far as I understand this config file is now useless since the main branch is not using NotebookApp but only ServerApp (see https://jupyter.org/enhancement-proposals/28-jupyter-server/jupyter-server.html). It was useful to keep both for compatibility with Notebook<7 and Jupyterlab (branch 0.8.x). We can probably try to remove it instead.

lahwaacz commented 1 year ago

@brichet Oh, right. I found a few more NotebookApp instances and removed them too.

brichet commented 1 year ago

@lahwaacz I've taken the liberty of renaming the PR for the sake of consistency.