search

jupyter / nbgrader

A system for assigning and grading notebooks
https://nbgrader.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.3k stars 317 forks source link

Release 0.9.0 breaks nbextensions #1828

Closed Adamtaranto closed 8 months ago

Adamtaranto commented 1 year ago

Operating system

Ubuntu

Python

3.11

nbgrader --version

=>0.9.0

jupyter notebook --version

6.5.5

Expected behaviour

Trying to activate nbgrader extension with command: jupyter nbextension install --sys-prefix --py nbgrader

Expect this to call jupyter-nbextension and install nbgrader extension

Actual behaviour

When nbgrader =>v0.9.0 is installed jupyter-nbextension is missing and calling the command above generates the following error:

Available subcommands: console dejavu events execute fileid kernel kernelspec lab labextension labhub migrate nbclassic nbconvert notebook qtconsole run server troubleshoot trust

Jupyter command jupyter-nbextension not found.

Steps to reproduce the behaviour

Install nbgrader v0.9.0 jupyter-nbextension will be removed even if you previously had it installed from an earlier version.

Reverting to nbgrader v0.8.5 resolves the issue.

lahwaacz commented 1 year ago

nbgrader v0.9.0 requires Jupyter Notebook 7: https://github.com/jupyter/nbgrader/blob/main/pyproject.toml#L45

Are you sure you have notebook 6.5.5? How did you install nbgrader?

Adamtaranto commented 1 year ago

Installed with pip3 install -r requirements.txt

Which installs:

nbgrader jupyter numpy pandas matplotlib biopython networkx regex

If I do this in a clean env notebook is 6.5.5

notebook 6.5.5 pypi_0 pypi

brichet commented 1 year ago

Thanks @Adamtaranto for reporting this.

I can't reproduce it locally, pip3 install -r requirements.txt installs Jupyterlab 4 and Notebook 7 (which is expected). Notebook 7 is using labextensions system, and not nbextensions.

If you want to run nbgrader on Notebook<7 you should use the 0.8.5 version.

These are not dependencies of nbgrader:

numpy pandas matplotlib biopython networkx regex

I suppose you did not only install the requirement.txt of nbgrader.

Can you see the same issue when pulling nbgrader from github and running pip3 install -r requirements.txt again ?

brichet commented 12 months ago

@Adamtaranto any update ? Should we close this issue ?

brichet commented 8 months ago

Feel free to reopen it if there are any update.