Fix autograde for students with backslash in their ID

jupyter / nbgrader

A system for assigning and grading notebooks

https://nbgrader.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

1.3k stars 317 forks source link

Fix autograde for students with backslash in their ID #1881

Open sydfromm opened 7 months ago

sydfromm commented 7 months ago

Currently, using autograde on a student with a backslash in their student id raises an error. Backslashes were not encoded properly and appeared as forward slashes in the post request.

This pr aims to fix #912 by encoding the full api call.

github-actions[bot] commented 7 months ago

:point_left: Launch a Binder on branch sydfromm/nbgrader/main

brichet commented 3 months ago

Thanks @sydfromm for this PR.

I can't test it since I don't have such environment available (server with AD domain).

Additionally, on my side the test passes with or without the modification in manage_submission.js.

Can you provide a test that won't pass without the modification?