search

jupyter / nbgrader

A system for assigning and grading notebooks
https://nbgrader.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
1.3k stars 317 forks source link

Fix the mit license link #1940

Closed brichet closed 4 days ago

github-actions[bot] commented 6 days ago

Binder :point_left: Launch a Binder on branch _brichet/nbgrader/fixlinks

lahwaacz commented 6 days ago

The LICENSE file is BSD-3-Clause, not MIT, though...

brichet commented 6 days ago

The LICENSE file is BSD-3-Clause, not MIT, though...

It is the license of a component used in formgrader.

lahwaacz commented 6 days ago

It is the license of a component used in formgrader.

Hmm what is the upstream of the component? Why do you update in this git repo? The top-level LICENSE file should still apply to the whole repo, but in this case it doesn't - a classical issue of a monorepo...

brichet commented 4 days ago

I agree, the choice of embedding javascript libraries seems to date back to the origins. Some notes about it in the doc: https://nbgrader.readthedocs.io/en/latest/contributor_guide/js_dependencies.html

We should probably get rid of these committed dependencies. But we should also avoid using bower as package management for the formgrader frontend, it is now unmaintained.

I'm closing this PR since it doesn't solve the problem anyway.