search

jupyter / nbmanager

View and stop running IPython notebook servers
51 stars 20 forks source link

switch to PyQt5 and QIcon.fromTheme #5

Closed flying-sheep closed 9 years ago

flying-sheep commented 9 years ago

fixes #3 and #4

the only problem is that PyUIC doesn’t seem to create fallbacks.

a way to fix it would be to replicate the freedesktop icon theme name hierarchy in the resources and add :/icons to QIcon.setThemeSearchPaths.

e.g.: :/icons/hicolor/16x16/mimetypes/x-ipynb+json.png would be the new path for :/icons/ipynb_icon_16x16.png

takluyver commented 9 years ago

Given my complaints about the nature of icon themes, and the trouble you mention with fallbacks, I'm closing this for now. I'd accept a PR just to convert to PyQt5, and we can discuss the icon stuff more if you want.