search

jupyter / nbviewer

nbconvert as a web service: Render Jupyter Notebooks as static web pages
https://nbviewer.jupyter.org
Other
2.19k stars 544 forks source link

Branch names are not url encoded #1059

Open taylor-schneider opened 2 months ago

taylor-schneider commented 2 months ago

Describe the bug The UI is not URL encoding branch names which leads to invalid URLs. For example, if the git repo has a branch named "feature/blah=blah" the UI will construct a url that contains "feature/blah-blah" rather than "feature%2fblah-blah"

To Reproduce Steps to reproduce the behavior:

  1. Open website
  2. Try to view notebook in branch with special char in name (e.g. this notebook)

Expected behavior The note book should load rather than send a 404

Desktop (please complete the following information):