Open jiffyclub opened 9 years ago
Ewwww, that's ugly on GitHub. I can't recall if @sshirokov and @arfon were going to look over this label, but you can also email support@github.com.
I emailed github and @sshirokov is on the case.
:smile:
This should be looking a lot nicer now, sorry about that
:cat2:
Thanks for closing the loop. Starry night looks great! :+1:
The GitHub rendering is still stripping <style>
tags and id
attributes, but it is a big improvement, thanks! The grids are the wrong size because the grid's custom CSS isn't overriding the user-agent stylesheets, but at least they are the right color.
It looks like some of this issue was addressed a long while back. Any reason to keep it open now?
Copied from ipython/nbconvert#204.
With GitHub's new notebook rendering ipythonblocks tables aren't rendered correctly as they are in nbviewer. Examples:
GitHub: https://github.com/jiffyclub/ipythonblocks/blob/master/demos/starry_night_to_text.ipynb nbviewer: http://nbviewer.ipython.org/github/jiffyclub/ipythonblocks/blob/master/demos/starry_night_to_text.ipynb
Looking at the HTML it looks like GitHub is stripping out
style
tags and attributes, andid
attributes:GitHub:
nbviewer: