search

jupyter / nbviewer

nbconvert as a web service: Render Jupyter Notebooks as static web pages
https://nbviewer.jupyter.org
Other
2.21k stars 548 forks source link

ipythonblocks not rendering on github.com #450

Open jiffyclub opened 9 years ago

jiffyclub commented 9 years ago

Copied from ipython/nbconvert#204.

With GitHub's new notebook rendering ipythonblocks tables aren't rendered correctly as they are in nbviewer. Examples:

GitHub: https://github.com/jiffyclub/ipythonblocks/blob/master/demos/starry_night_to_text.ipynb nbviewer: http://nbviewer.ipython.org/github/jiffyclub/ipythonblocks/blob/master/demos/starry_night_to_text.ipynb

Looking at the HTML it looks like GitHub is stripping out style tags and attributes, and id attributes:

GitHub: screenshot 2015-05-07 13 10 15

nbviewer: screenshot 2015-05-07 13 09 28

rgbkrk commented 9 years ago

Ewwww, that's ugly on GitHub. I can't recall if @sshirokov and @arfon were going to look over this label, but you can also email support@github.com.

jiffyclub commented 9 years ago

I emailed github and @sshirokov is on the case.

rgbkrk commented 9 years ago

:smile:

sshirokov commented 9 years ago

This should be looking a lot nicer now, sorry about that

:cat2:

bollwyvl commented 9 years ago

Thanks for closing the loop. Starry night looks great! :+1:

jiffyclub commented 9 years ago

The GitHub rendering is still stripping <style> tags and id attributes, but it is a big improvement, thanks! The grids are the wrong size because the grid's custom CSS isn't overriding the user-agent stylesheets, but at least they are the right color.

parente commented 6 years ago

It looks like some of this issue was addressed a long while back. Any reason to keep it open now?