search

jupyter / notebook

Jupyter Interactive Notebook
https://jupyter-notebook.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
11.59k stars 4.86k forks source link

Bootstrap interferes with CSS #1107

Open blink1073 opened 8 years ago

blink1073 commented 8 years ago

We noticed the following when running #972: the inclusion of bootstrap CSS has highly pervasive consequences, including adding * and element level rules. I removed bootstrap from the Lab page.

image

blink1073 commented 8 years ago

@jdfreder, thoughts on this, since you are using it in jupyter-js-widgets?

blink1073 commented 8 years ago

Possible workaround: http://hereswhatidid.com/2014/02/use-bootstrap-3-styles-within-the-wordpress-admin/

ellisonbg commented 8 years ago

Ouch, this sucks. There are a lot of places we use bootstrap and I think it will be pretty painful to get rid of it. It is not just in ipywidgets, but elsewhere in our UI where people building extensions rely on it a lot...hmmm

On Thu, Feb 18, 2016 at 11:08 AM, Steven Silvester <notifications@github.com

wrote:

@jdfreder https://github.com/jdfreder, thoughts on this, since you are using it in jupyter-js-widgets?

— Reply to this email directly or view it on GitHub https://github.com/jupyter/notebook/issues/1107#issuecomment-185866044.

Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

afshin commented 8 years ago

If that workaround proves viable, the transition won't be too painful. Each extension would just need a wrapper class on its root node and it'll work exactly as is. But it will require any Bootstrap-using extension to be modified in that way.

jdfreder commented 8 years ago

I'd prefer to not use bootstrap at all in the widgets, but because we use it in the notebook it provides a consistent rendering experience.

sccolbert commented 8 years ago

Except when it breaks 3rd party code ;-)