jupyter / notebook

Jupyter Interactive Notebook
https://jupyter-notebook.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
11.58k stars 4.85k forks source link

Can't use the keyboard shortcut to open the command palette on Firefox #2645

Open vharsh opened 7 years ago

vharsh commented 7 years ago

Firefox uses [ctrl] + [shift] + [p] to open a Private Window and Chromium uses it to open the print dialog when I am not in insert mode. I have not been able to open the palette in Firefox when I am in any mode, I can open it in Chromium when I am in Insert mode.

Should it be changed to something else which isn't already a shortcut in the popular browsers, so that it can be opened irrespective of the mode the user is in?

takluyver commented 7 years ago

We already added Ctrl-Shift-F as an alternative shortcut for the same thing.

vharsh commented 7 years ago

Sorry for this issue. This wasn't listed in the docs.

takluyver commented 7 years ago

Want to make a PR for the docs? ;-)

vharsh commented 7 years ago

I'd love to after I find a few similar things to fix. I had found a typo of toolbar in source/extending/frontend_extensions.rst as toolabr. Moreover I have some confusions between server-extensions and nbserver extensions, regarding which one is deprecated and which one is more suitable for a particular use-case.

takluyver commented 7 years ago

nbserver_extensions is recommended now, server_extensions is deprecated.

vharsh commented 7 years ago

I have a little confusion regarding this. What I know as of now, by reading...

What I am trying to do?

Newbie so far, vharsh on Freenode

takluyver commented 7 years ago

Yeah, the docs have basically always said that the Javascript API isn't stable. It hasn't stopped people using it. ;-)

From that blog post:

Add some functionality to make interaction with git&github easier from the front-end. I am not getting very helpful messages in the browser's JavaScript console, which points to some main.min.js.

Yeah, sorry about that. There are supposed to be source maps which let it point to the real location, but they don't seem to work reliably.

I can bring up buttons by writing JavaScript in the Notebook cell with the %%javascript magic-flags. I can't figure out if the .js file has to be in ~/.jupyer/custom/custom.js or ~/.local/share/jupyter/nbextensions.

custom.js is intended to be a simple mechanism for a user to customise their own installation. Nbextensions are for extension packages which you can write and distribute. Nbextensions have to be enabled (see jupyter nbextension enable --help) before they are loaded, whereas custom.js is loaded by default if it exists.