search

jupyter / notebook

Jupyter Interactive Notebook
https://jupyter-notebook.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
11.52k stars 4.82k forks source link

Visual design of marked cell, In/Out prompts #610

Open ellisonbg opened 8 years ago

ellisonbg commented 8 years ago

In master we have introduced some new blue colors for the marked cell indicator and In prompt. Looks a bit funny against the bold darkred of the Out prompt. @cameronoelsen can you do some prototypes of a color scheme for the cell that:

ellisonbg commented 8 years ago

I talking to @Carreau we may want to keep the visual style of existing things the same over the 4.x releases. Need to discuss with everyone.

cameronoelsen commented 8 years ago

I have been looking and playing with the notebook and really don't like the blue anymore. Took your advice @ellisonbg and mocked up the notebook with less color variations like the landing page.

Or should I just go with the blue and the above suggestions. Just thought this was worth trying out!

preview1 preview2

minrk commented 8 years ago

orange and red don't have enough contrast between them for input/output, for me.

ellisonbg commented 8 years ago

Agree with @minrk on that point. In the long run we may end up doing more significant design changes to how cells are styled. @Carreau and I were talking yesterday that we probably shouldn't change UI in minor releases. I am going to send an email to the list about this and some other versioning questions.

For the 4.1 release, we should probably keep the prompts the same as in 4.0.

But let's wait until the larger discussion about versioning finishes before doing anything with this.

On Fri, Oct 16, 2015 at 6:03 AM, Min RK notifications@github.com wrote:

orange and red don't have enough contrast between them for input/output, for me.

— Reply to this email directly or view it on GitHub https://github.com/jupyter/notebook/issues/610#issuecomment-148673455.

Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com

Carreau commented 8 years ago

Visual style has been reverted (except for marked cell which is "new".

Can we bump that to 5.0 ?

ellisonbg commented 8 years ago

Yep, bump...

On Thu, Oct 22, 2015 at 1:39 PM, Matthias Bussonnier < notifications@github.com> wrote:

Assigned #610 https://github.com/jupyter/notebook/issues/610 to @ellisonbg https://github.com/ellisonbg.

— Reply to this email directly or view it on GitHub https://github.com/jupyter/notebook/issues/610#event-442922812.

Brian E. Granger Associate Professor of Physics and Data Science Cal Poly State University, San Luis Obispo @ellisonbg on Twitter and GitHub bgranger@calpoly.edu and ellisonbg@gmail.com