search

jupyter / notebook

Jupyter Interactive Notebook
https://jupyter-notebook.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
11.75k stars 4.99k forks source link

V7: Left-Right sidebar bug /questions ? #6826

Open Carreau opened 1 year ago

Carreau commented 1 year ago

Left Sidebar menu only suggest "Show table of content"top menu with a checkmark ?

The Right sidebar menu suggest Debugger and Notebook Tools.

Should it be just a "Show table of content" top menu, or were the three Notebook Tools, Debugger and TOC supposed to be showable left and right ?

Additionally "Notebook tools" is a blank panel for me. If it's supposed to only show things sometimes, maybe add a placeholder text saying "this will show X, Y, Z, when P1, P2, P3" ?

jtpio commented 1 year ago

Thanks for reporting :+1:

Additionally "Notebook tools" is a blank panel for me. If it's supposed to only show things sometimes, maybe add a placeholder text saying "this will show X, Y, Z, when P1, P2, P3" ?

cc @brichet: maybe it's related to the metadata form rework upstream in JupyterLab?

Wondering that we could probably put the notebook tools panel under UI tests like for the Table of Contents to make sure it's displayed correctly?

brichet commented 1 year ago

cc @brichet: maybe it's related to the metadata form rework upstream in JupyterLab?

Wondering that we could probably put the notebook tools panel under UI tests like for the Table of Contents to make sure it's displayed correctly?

We probably need to add a dependency on @jupyterlab/metadataform if it not already the case.

I can take a look at this.

jtpio commented 1 year ago

I can take a look at this.

That would be great, thanks!

brichet commented 1 year ago

I opened https://github.com/jupyter/notebook/pull/6834 to fix the notebooktools right panel.

Wondering that we could probably put the notebook tools panel under UI tests like for the Table of Contents to make sure it's displayed correctly?

There were already ui-tests but the blank panels had been pushed as reference snapshots :smile:

jtpio commented 1 year ago

Should it be just a "Show table of content" top menu, or were the three Notebook Tools, Debugger and TOC supposed to be showable left and right ?

@Carreau some panels should be displayed on the left, others on the right. Some panels might also be added by third-party extensions. So there could be more than one entry for the left sidebar.

Carreau commented 1 year ago

@Carreau some panels should be displayed on the left, others on the right. Some panels might also be added by third-party extensions. So there could be more than one entry for the left sidebar.

Ok, no worries, feel free to close. It just feel weird to no be able to chose left/right as I had the impression it was possible in JLab.

jtpio commented 1 year ago

It just feel weird to no be able to chose left/right as I had the impression it was possible in JLab.

Switching sidebar side could likely still be implemented. Maybe as part of https://github.com/jupyter/notebook/issues/6688 so it can be configured via the settings.

Bumping to 7.1.0 to keep it on the radar.