search

jupyter / notebook

Jupyter Interactive Notebook
https://jupyter-notebook.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
11.73k stars 4.97k forks source link

Cry for help, please, give us "right button" and "ctrl+F" back! #7246

Closed avloss closed 9 months ago

avloss commented 9 months ago

This is just my opinion, but I find it extremely frustrating when functionality like "right button" or "ctrl+F" (page search) are overridden. When I press right button I expect to see MY menu, I have custom Chrome plugins which modify it. I expect to see "Open Link In a New Tab", I expect to see "Copy" and what I always see, on every other website. Left button is functional, and surely developers should make the most of it, but "Right Button" is "personal user space", please do not override it with any functionality. Same for page search - as I user I'm used to certain behaviour when I search on a web page - where and how search field would appear and how it'll behave - please do NOT override it! Also, when I click on BreadCrumbs in "Tree View" with right button - I expect "open in a new Tab", but it's not there. We as users are used to certain ways of interacting with a web-page. Please do not override those basic browser functions (Right Click, Ctrl+F).

This is more of an emotional appeal, I really love using Jupyter Notebook, and it's been a huge part of my professional career. But what Notebook 7 is becoming is almost unusable to me. People who want that "immersive lab experience" can surely use Jupyter Lab, but for those who want to treat Notebook as an "interactive web page" - we really do want to have it act as a web page.

This is more of a cry-for-help. I've downgraded to 6.5.6 after using 7 for quite some time. I understand that it's unlikely that it'll happen, but I just want there to be awareness, that people who didn't switch to "Jupyter Lab" already just want their normal Notebook, with predictable behaviour.

Right now there's "nbclassic" but it's prompting for "migration", so my understanding is it'll be discontinued sooner than later.

jtpio commented 9 months ago

Thanks @avloss for opening the issue.

When I press right button I expect to see MY menu

The context menu is indeed inherited from JupyterLab. However you should be able to open the default browser context menu by holding Shift before right-clicking:

image

CTRF-F

This was indeed the case for a while before the final release of Notebook 7. However it was causing issues because the default browser search was not able to find elements on the page. See https://github.com/jupyter/notebook/pull/6905 for more details.

You may want to disable that shortcut as mentioned in https://jupyter-notebook.readthedocs.io/en/stable/notebook.html#searching

avloss commented 9 months ago

Shift

Thanks, didn't know that!

CTRF-F

For me it only searches code, but not the cell output, which is most of the time not what I expect. Perhaps that's by design.

Screenshot 2024-02-08 at 22 19 18
jtpio commented 9 months ago

Thanks, didn't know that!

Happy to add more documentation to the migration guide or other places in the docs, if you think that would be useful. Maybe also to document how to disable the context menu entirely.

For me it only searches code, but not the cell output, which is most of the time not what I expect. Perhaps that's by design.

You may need to expand the search filters and select "Search Cell Outputs":

image

Do you think this should be enabled by default? If so maybe this can be submitted as a feature request in https://github.com/jupyterlab/jupyterlab?

avloss commented 9 months ago

Thank you for your response! I'll close the issue now.