search

jupyter / notebook

Jupyter Interactive Notebook
https://jupyter-notebook.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
11.56k stars 4.84k forks source link

Redirection Screen Should Match theme #7390

Open Michael13435 opened 3 months ago

Michael13435 commented 3 months ago

Problem

Redirection screen that directs to jupyter is always white, regardless of system, browser, or jupyter theme

Proposed Solution

Jupyter's redirection screen should preferably match the browser, or the theme chosen for Jupyter if the former is not possible

RRosio commented 3 months ago

@Michael13435 thank you for reporting this! Could you share which version of Notebook you are using?

@JasonWeill does see a flash of white when using Notebook 7 in Dark Mode.

From @krassowski, https://github.com/jupyter/notebook/blob/9c70c1367e0895eadb677fa9543d2d31ffb24a48/packages/application-extension/src/index.ts#L492-L516, is the Notebook splash screen which should be covering the entire screen in a dark-gray color.

Michael13435 commented 3 months ago

@Michael13435 thank you for reporting this! Could you share which version of Notebook you are using?

@JasonWeill does see a flash of white when using Notebook 7 in Dark Mode.

From @krassowski,

https://github.com/jupyter/notebook/blob/9c70c1367e0895eadb677fa9543d2d31ffb24a48/packages/application-extension/src/index.ts#L492-L516 , is the Notebook splash screen which should be covering the entire screen in a dark-gray color.

I saw this behaviour on jupyter version 6.5.4

JasonWeill commented 3 months ago

@Michael13435 Thank you for your response! Notebook 6 is now maintained as nbclassic. I would recommend opening an issue in nbclassic if you intend to keep using Notebook 6; otherwise, we will fix this in Notebook 7 in this repository.