search

jupyter / qtconsole

Jupyter Qt Console
https://qtconsole.readthedocs.io/en/stable/
BSD 3-Clause "New" or "Revised" License
413 stars 199 forks source link

Use selected syntax style for tracebacks and improve ANSI color codes support #608

Closed jsbautista closed 1 month ago

jsbautista commented 4 months ago

Fixed traceback higlight, making use of the VerboseTB hack and adding a color homologation to expand the range of colors used by QtConsole Before: BeforeQtConsole BeforeQtConsolea (online-video-cutter com)

After:

AfterQtConsole AfterQtConsolea

related issues https://github.com/spyder-ide/spyder/issues/4891

jsbautista commented 4 months ago

@dalthviz

dalthviz commented 3 months ago

Note: The latest failing tests on linux and mac are unrelated with the work here, seems like a message about the debugger and frozen modules (the one that mentions things like using PYDEVD_DISABLE_FILE_VALIDATION=1 and -Xfrozen_modules=off) is being caught when doing the tests related with communications between frontend and kernel/kernel and frontend

Edit: Multiple CI reruns helps things pass on linux but probably something to check. Maybe that is the reason why the related tests have a high number of retries (flacky marked with 10 tries) 🤔

ccordoba12 commented 1 month ago

Just in case, do you have any further comments @ccordoba12? Should we wait until https://github.com/ipython/ipython/pull/14476 gets merged to merge this or we could merge this regardless?

Nop, I don't have more comments, so please merge it. If https://github.com/ipython/ipython/pull/14476 goes in a different route, we can simply adapt the code here.