search

jupyter / services

This repository is deprecated. It has been moved to https://github.com/jupyterlab/jupyterlab as a sub-package
BSD 3-Clause "New" or "Revised" License
72 stars 45 forks source link

Clean up websocket closing #296

Open blink1073 opened 7 years ago

blink1073 commented 7 years ago

Model after https://github.com/jupyter/notebook/commit/255ae89.

minrk commented 7 years ago

BTW, I reverted that commit because I found the real bug (a race condition setting .onclose), and went with https://github.com/jupyter/notebook/pull/2011/commits/f587b01f6696342859ef8478a7a66da84011e261 instead.