jupyter / terminado

Terminals served by tornado websockets
http://terminado.readthedocs.org/en/latest/
BSD 2-Clause "Simplified" License
368 stars 95 forks source link

Add test for terminating the terminals #142

Closed blink1073 closed 2 years ago

blink1073 commented 2 years ago

Heads up @andfoy, it looks like we're not able to properly terminate terminals anymore in pywinpty 2.0+.

 >       assert self.single_tm.terminal.ptyproc.closed
E       assert False

https://github.com/blink1073/terminado/runs/5162491817?check_suite_focus=true

The terminate function is returning True, as asserted in the test, but the ptyproc is not closing, and not triggering EOF.

I'll try and do some more debugging next week.

andfoy commented 2 years ago

Thanks for the ping, please let me know if I can help in any way

andfoy commented 2 years ago

@blink1073, I've just released pywinpty v2.0.3, it should be available in a few minutes

blink1073 commented 2 years ago

I've just released pywinpty v2.0.3, it should be available in a few minutes

Thanks!

blink1073 commented 2 years ago

@andfoy it works now when I specify using the WinPTY backend!