Closed yusufbashi closed 2 years ago
As the author of https://github.com/jupyter/terminado/pull/127, I had considered this when submitting this PR
!
magic)Therefore, for this problem, I think you can appropriately adjust the maxlen to 200 or 500 or more, but over 10,000 may not be a good choice.
I dropped the value to 800 and it still seems to greatly alleviate the issue I linked. 800 is most likely low enough to accommodate users with low bandwidth, but if any bandwidth issues come up we should be able to decrease it further without any ill effects.
I think for those kind of need the best answer is no absolute answer - aka making it configurable.
See the best would be to add a new setting in term_settings
That can be passed to PtyWithClients
constructor
It will then be possible to add a new configurable trait in Jupyter server to tune the value (transferring it to term_settings
).
I think for those kind of need the best answer is no absolute answer - aka making it configurable.
See the best would be to add a new setting in
term_settings
That can be passed to
PtyWithClients
constructorIt will then be possible to add a new configurable trait in Jupyter server to tune the value (transferring it to
term_settings
).
I agree. The user can decide how much content to cache, especially since Jupyterhub and other similar sites have
We can implement this in jupyter_server_terminal, configure terminado when jupyter_server_terminal is enabled
We can implement this in jupyter_server_terminal, configure terminado when jupyter_server_terminal is enabled
Thanks for pointing that project (I was not aware of it). Is the plan to make jupyter_server
depends on it to avoid code duplication?
We can implement this in jupyter_server_terminal, configure terminado when jupyter_server_terminal is enabled
Thanks for pointing that project (I was not aware of it). Is the plan to make
jupyter_server
depends on it to avoid code duplication?
Yes, you can refer this https://github.com/jupyter-server/jupyter_server/pull/651
jupyter_server_terminal is designed to replace the terminals
in jupyter_server
The default in iterm2
is 1000, how about we start with that?
Alleviates https://github.com/jupyterlab/jupyterlab/issues/10633. A full solution should take the users choice of scrollback history length into consideration rather than setting a constant value of "maxlen" on line 44.