jupyter / terminado

Terminals served by tornado websockets
http://terminado.readthedocs.org/en/latest/
BSD 2-Clause "Simplified" License
365 stars 94 forks source link

Don't split manually on linebreaks #209

Closed incase closed 1 year ago

incase commented 1 year ago

Use splitlines() instead of manually splitting on \r or \n. Use the first line that looks like a PID (all numbers, as re.match only looks at the start of the line and the regex only allows numbers until end of line anchor).

Fixes https://github.com/jupyter/terminado/issues/84

blink1073 commented 1 year ago

I'll cut a patch release early next week.