jjhelmus
commented
6 years ago Tested that jupyter notebook and jupyter lab will open a Powershell is bash is not installed. terminado works fine without bash, the only concern is tests.
Open jjhelmus opened 6 years ago
jjhelmus
commented
6 years ago Tested that jupyter notebook and jupyter lab will open a Powershell is bash is not installed. terminado works fine without bash, the only concern is tests.
bollwyvl
commented
4 years ago Verified this on https://github.com/conda-forge/terminado-feedstock/pull/16 ... py36 runs fine once it has posix as a test dependency.
A few other tests also failed on different windows/python combinations, with these skips (hopefully) clearing it up...
{% set skips = "-k 'not single_process'" %} # [win and py37]
{% set skips = "-k 'not (namespace or basic_command)'" %} # [win and py38]Perhaps it's time to move this to azure pipelines/github actions and get some deeper coverage...
The unit tests make calls to unix utilities including bash and whoami. There are various method for installing these in Windows, WSL, Cygwin, MSYS2, but they are not installed on many systems. The unit tests fail if these utilities are not installed
and I suspect that terminado does not work properly in these cases.The AppVeyor build enviornment does provide these tools via MinGW, MSYS and Cygwin which explains the passing CI.
Is the expectation that terminado requires these utilities on Windows?