search

jupyter / tmpnb-redirector

Simple HTTP redirector for tmpnb nodes
BSD 3-Clause "New" or "Revised" License
12 stars 16 forks source link

Use of Hipache? #3

Closed natea closed 9 years ago

natea commented 9 years ago

hey Kyle - have you thought about using Hipache for this? It would introduce more complexity (because there's a dependency on Redis), but it would be one less thing for you to have to maintain. https://github.com/hipache/hipache

Blog post about it: http://blog.dotcloud.com/under-the-hood-dotcloud-http-routing-layer

rgbkrk commented 9 years ago

Hey @natea!

Yeah, and I've actually tried using it. The current websocket proxying on Hipache doesn't work with the IPython notebook's websockets. Once I got to that point, I didn't go much further than seeing how development was going on hipache/hipache.

There is always the possibility that I just configured it improperly, so if you have the notebook working with it I'd be really happy to see.

natea commented 9 years ago

Hmm... that's strange that the Hipache websockets didn't work with the IPython Notebook's websockets. I'm not much of a Hipache expert, but maybe if you created an issue in the Hipache issue tracker, someone who knows more about it than I do, could take a look. As you said, it might be a simple configuration switch.

On Sat, Nov 22, 2014 at 10:52 AM, Kyle Kelley notifications@github.com wrote:

Hey @natea https://github.com/natea!

Yeah, and I've actually tried using it. The current websocket proxying on Hipache doesn't work with the IPython notebook's websockets. Once I got to that point, I didn't go much further than seeing how development was going on hipache/hipache.

There is always the possibility that I just configured it improperly, so I'm more than happy to see it working in action from someone else.

— Reply to this email directly or view it on GitHub https://github.com/jupyter/tmpnb-redirector/issues/3#issuecomment-64084492 .

nate@appsembler.com +1 (617) 517-4953 http://twitter.com/natea | http://linkedin.com/in/natea

rgbkrk commented 9 years ago

Yeah, I can take a stab at it again and hopefully have something resembling a real issue to report on hipache's tracker.

When I tried out hipache, it was the weekend before the Nature demo was going live. Since I couldn't get it to work, I fell back to known tested pieces. When we surged even more, I outlined what I really wanted to do with our health endpoint (/stats) and @minrk whipped this together quickly.

Carreau commented 9 years ago

We considered it at the beginning also, and deemed it would be better writing the config-http-proxy from scratch.