jupyter / tmpnb

Creates temporary Jupyter Notebook servers using Docker containers. [DEPRECATED - See BinderHub project]
https://github.com/jupyterhub/binderhub
BSD 3-Clause "New" or "Revised" License
528 stars 123 forks source link

allow using docker networks #258

Closed minrk closed 7 years ago

minrk commented 7 years ago

and use them in make dev

which is needed for OS X / etc. where host networking only sort-of exists

I needed this to test #257 because host networking doenn't work on Docker for Mac.

willingc commented 7 years ago

@minrk When you refer to Docker for Mac, I'm assuming that you mean the beta for Docker on Mac. Correct?

minrk commented 7 years ago

@willingc yup, I mean the current Docker for Mac tools, but the same thing is true for every version of docker that can be used from macOS or Windows (boot2docker, docker-machine, etc.), due to the extra hop between the user's environment and the 'host' VM where docker is actually running.