search

jupyter / tmpnb

Creates temporary Jupyter Notebook servers using Docker containers. [DEPRECATED - See BinderHub project]
https://github.com/jupyterhub/binderhub
BSD 3-Clause "New" or "Revised" License
528 stars 123 forks source link

Fix cull_max option #262

Closed bryanwweber closed 7 years ago

bryanwweber commented 7 years ago

I noticed that my containers were being culled at one hour, no matter what the cull_max option was set to, and tracked it down to the setting of max_age (not opts.max_age though). I also noticed that containers were being added to the stale list, even if they hadn't been started yet. I'm not sure if this is necessary, but I made it so containers would have to be started before they were added to the list. Finally, I fixed a few typos in README and I just noticed that my editor automatically removed some EOL whitespace. Please let me know if this is useful or not, particularly the stale change. Thanks for an awesome script!

rgbkrk commented 7 years ago

Wow, thanks.

willingc commented 7 years ago

Thanks @bryanwweber for the contribution and kind words. We hope to see you around the jupyter and jupyterhub projects with future contributions ;-) Also, your cantera project looks really neat.

bryanwweber commented 7 years ago

@willingc Thanks! This semester and last semester, I've been using Jupyter Notebooks for my classes here at UConn and slowly figuring things out, so I hope to be able to give back soon.

willingc commented 7 years ago

@bryanwweber That's great. As an FYI, there is a Jupyter in Education mailing list/google group (low volume, good content). Good luck with classes and feel free to reach out or say hello on JupyterHub gitter.